WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#31972 closed defect (bug) (fixed)

Discussion Settings shows always the personal avatar for HighDPI screens

Reported by: ocean90's profile ocean90 Owned by: ocean90's profile ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: General Keywords: has-patch
Focuses: Cc:

Description

Previoulsy: ticket:21195:59

On Discussion Settings the default Gravatar is forced via $avatar_list .= preg_replace("/src='(.+?)'/", "src='\$1&forcedefault=1'", $avatar); which doesn't match the srcset attribute added in [31721].

​https://cloudup.com/cpjdZkP0IiG or https://core.trac.wordpress.org/attachment/ticket/21195/21195.16.diff won't work, because we don't know if the arguments work for get_avatar().

Attachments (1)

31972.patch​ (848 bytes) - added by SergeyBiryukov 10 years ago.

Download all attachments as: .zip

Change History (3)

@SergeyBiryukov
10 years ago

#1 @SergeyBiryukov
10 years ago

  • Keywords has-patch added; needs-patch removed

#2 @ocean90
10 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 32129:

Force default avatar for HiDPI avatars on Discussion Settings.

props SergeyBiryukov.
fixes #31972.

Note: See TracTickets for help on using tickets.
OSZAR »